Bug 134952

Summary: [iOS][WK2] Scrolling request from the scrolling tree must be limited to offsets in the document
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: enrica, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch enrica: review+

Benjamin Poulain
Reported 2014-07-15 16:29:19 PDT
[iOS][WK2] Scrolling request from the scrolling tree must be limited to offsets in the document
Attachments
Patch (6.55 KB, patch)
2014-07-15 16:56 PDT, Benjamin Poulain 		enrica: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-07-15 16:56:26 PDT
Created attachment 234965 [details] Patch
Benjamin Poulain
Comment 2 2014-07-15 16:58:06 PDT
<rdar://problem/17647116>
Enrica Casucci
Comment 3 2014-07-15 17:00:48 PDT
Comment on attachment 234965 [details] Patch Looks reasonable to me.
Simon Fraser (smfr)
Comment 4 2014-07-15 17:01:54 PDT
Comment on attachment 234965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234965&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1001 > + if (contentOffsetInDocument.x() > maximumHorizontalOffset) > + contentOffsetInDocument.setX(maximumHorizontalOffset); > + if (contentOffsetInDocument.x() < 0) > + contentOffsetInDocument.setX(0); Maybe something with std::min(std::max(x, 0), max)? > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1010 > + CGPoint adjustedContentOffset = [self _adjustedContentOffset:contentOffsetInDocument]; Blank line above this please.
Benjamin Poulain
Comment 5 2014-07-15 17:20:24 PDT
Committed r171124: <http://trac.webkit.org/changeset/171124>
Note You need to log in before you can comment on or make changes to this bug.