Summary: | [iOS][WK2] Scrolling request from the scrolling tree must be limited to offsets in the document | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | enrica, simon.fraser | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Benjamin Poulain
2014-07-15 16:29:19 PDT
Created attachment 234965 [details]
Patch
Comment on attachment 234965 [details]
Patch
Looks reasonable to me.
Comment on attachment 234965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234965&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1001 > + if (contentOffsetInDocument.x() > maximumHorizontalOffset) > + contentOffsetInDocument.setX(maximumHorizontalOffset); > + if (contentOffsetInDocument.x() < 0) > + contentOffsetInDocument.setX(0); Maybe something with std::min(std::max(x, 0), max)? > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1010 > + CGPoint adjustedContentOffset = [self _adjustedContentOffset:contentOffsetInDocument]; Blank line above this please. Committed r171124: <http://trac.webkit.org/changeset/171124> |