Bug 134928

Summary: ScriptExecutable::forEachCodeBlock can dereference null CodeBlocks
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Mark Hahnenberg 2014-07-15 10:38:22 PDT 
Executable::forEachCodeBlock doesn't check for null CodeBlocks in the ProgramExecutable and EvalExecutable cases, so if the CodeBlock has been cleared from either of these Executables we'll crash when dereferencing null inside whatever functor was passed.
Comment 1 Mark Hahnenberg 2014-07-15 10:40:23 PDT 
Created attachment 234937 [details]
Patch
Comment 2 Andreas Kling 2014-07-15 11:02:03 PDT 
Comment on attachment 234937 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-07-15 12:12:24 PDT 
Comment on attachment 234937 [details]
Patch

Clearing flags on attachment: 234937

Committed r171108: <http://trac.webkit.org/changeset/171108>
Comment 4 WebKit Commit Bot 2014-07-15 12:12:27 PDT 
All reviewed patches have been landed.  Closing bug.