Bug 134928

Summary:

ScriptExecutable::forEachCodeBlock can dereference null CodeBlocks

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Mark Hahnenberg

Reported 2014-07-15 10:38:22 PDT

Executable::forEachCodeBlock doesn't check for null CodeBlocks in the ProgramExecutable and EvalExecutable cases, so if the CodeBlock has been cleared from either of these Executables we'll crash when dereferencing null inside whatever functor was passed.

Attachments
Patch (1.74 KB, patch) 2014-07-15 10:40 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Hahnenberg

Comment 1 2014-07-15 10:40:23 PDT

Created attachment 234937 [details] Patch

Andreas Kling

Comment 2 2014-07-15 11:02:03 PDT

Comment on attachment 234937 [details] Patch r=me

WebKit Commit Bot

Comment 3 2014-07-15 12:12:24 PDT

Comment on attachment 234937 [details] Patch Clearing flags on attachment: 234937 Committed r171108: <http://trac.webkit.org/changeset/171108>

WebKit Commit Bot

Comment 4 2014-07-15 12:12:27 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.