Bug 134922

Summary:

Implement CanvasPathMethod NoInterfaceObject

Product:

WebKit

Reporter:

Dirk Schulze <krit>

Component:

Canvas

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, bunhere, cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rakuco, rniwa, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review-, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none

Dirk Schulze

Reported 2014-07-15 05:06:16 PDT

Implement CanvasPathMethod NoInterfaceObject, as specified.

Attachments
Patch (11.49 KB, patch) 2014-07-15 05:11 PDT, Dirk Schulze	darin: review- buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (596.85 KB, application/zip) 2014-07-15 06:16 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (559.31 KB, application/zip) 2014-07-15 07:39 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Dirk Schulze

Comment 1 2014-07-15 05:11:23 PDT

Created attachment 234915 [details] Patch

Build Bot

Comment 2 2014-07-15 06:16:21 PDT

Comment on attachment 234915 [details] Patch Attachment 234915 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6022256249536512 New failing tests: canvas/philip/tests/2d.path.bezierCurveTo.nonfinite.html canvas/philip/tests/2d.path.arc.nonfinite.html canvas/philip/tests/2d.path.quadraticCurveTo.nonfinite.html canvas/philip/tests/2d.path.rect.nonfinite.html canvas/philip/tests/2d.path.moveTo.nonfinite.html canvas/philip/tests/2d.path.arcTo.nonfinite.html media/W3C/video/networkState/networkState_during_loadstart.html fast/canvas/canvas-with-incorrect-args.html canvas/philip/tests/2d.path.lineTo.nonfinite.html fast/canvas/canvas-path-with-inf-nan-dimensions.html

Build Bot

Comment 3 2014-07-15 06:16:25 PDT

Created attachment 234919 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 4 2014-07-15 07:39:33 PDT

Comment on attachment 234915 [details] Patch Attachment 234915 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4814959733112832 New failing tests: canvas/philip/tests/2d.path.bezierCurveTo.nonfinite.html canvas/philip/tests/2d.path.arc.nonfinite.html canvas/philip/tests/2d.path.quadraticCurveTo.nonfinite.html canvas/philip/tests/2d.path.rect.nonfinite.html canvas/philip/tests/2d.path.moveTo.nonfinite.html canvas/philip/tests/2d.path.arcTo.nonfinite.html fast/canvas/canvas-with-incorrect-args.html canvas/philip/tests/2d.path.lineTo.nonfinite.html fast/canvas/canvas-path-with-inf-nan-dimensions.html

Build Bot

Comment 5 2014-07-15 07:39:37 PDT

Created attachment 234925 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Darin Adler

Comment 6 2014-08-19 09:16:06 PDT

Comment on attachment 234915 [details] Patch Looks OK. Need to address failing tests.

Dirk Schulze

Comment 7 2016-10-12 05:07:44 PDT

This has been implemented as CanvasPath. The naming is not according to the spec but not visible to the user anyway.

Note You need to log in before you can comment on or make changes to this bug.