Summary: | Allow for Int52Rep to see things other than Int32, and make this testable | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2014-07-13 14:47:17 PDT
Created attachment 234832 [details]
work in progress
Still have to write the FTL lowering for MachineIntUse and DoubleRepMachineIntUse, and then I have to write tests that use FiatInt52.
Created attachment 234834 [details]
more
Still have a bunch of tests to write.
Created attachment 234875 [details]
the patch
Comment on attachment 234875 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=234875&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + wants and we'll still valid valid IR after Fixup. This previously didn't work with Int52s. valid valid => produce valid Comment on attachment 234875 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=234875&action=review r=me too >> Source/JavaScriptCore/ChangeLog:9 >> + wants and we'll still valid valid IR after Fixup. This previously didn't work with Int52s. > > valid valid => produce valid have valid IR? Landed in http://trac.webkit.org/changeset/171096 |