Summary: | Move composite bounds calculation to RenderLayerBacking. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
zalan
2014-07-12 18:57:16 PDT
RenderLayerCompositor was just proxying the calculateLayerBounds() to the RenderLayer. Created attachment 234820 [details]
Patch
Comment on attachment 234820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234820&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:-976 > - if (!canBeComposited(layer)) > - return LayoutRect(); The patch deletes this check. Why isn’t this needed? (In reply to comment #3) > (From update of attachment 234820 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234820&action=review > > > Source/WebCore/rendering/RenderLayerCompositor.cpp:-976 > > - if (!canBeComposited(layer)) > > - return LayoutRect(); > > The patch deletes this check. Why isn’t this needed? the m_owningLayer of the RenderLayerBackig is always composited so that check should always evaluate to true, but I'll check with smfr before landing. Comment on attachment 234820 [details] Patch Attachment 234820 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6458563052437504 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html Created attachment 234822 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
(In reply to comment #5) > (From update of attachment 234820 [details]) > Attachment 234820 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/6458563052437504 > > New failing tests: > media/W3C/video/networkState/networkState_during_loadstart.html seems unrelated. Comment on attachment 234820 [details] Patch Attachment 234820 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6541610808508416 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html Created attachment 234825 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 234864 [details]
Patch
Comment on attachment 234864 [details]
Patch
EWS testing
Comment on attachment 234864 [details] Patch Clearing flags on attachment: 234864 Committed r171073: <http://trac.webkit.org/changeset/171073> All reviewed patches have been landed. Closing bug. |