Bug 134864 – Move composite bounds calculation to RenderLayerBacking.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

for better functionality encapsulation.

[alan]

RenderLayerCompositor was just proxying the calculateLayerBounds() to the RenderLayer.

[alan]

Created attachment 234820 [details]
Patch

[Darin Adler]

Comment on attachment 234820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234820&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:-976
> -    if (!canBeComposited(layer))
> -        return LayoutRect();

The patch deletes this check. Why isn’t this needed?

[alan]

(In reply to comment #3)
> (From update of attachment 234820 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234820&action=review
> 
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:-976
> > -    if (!canBeComposited(layer))
> > -        return LayoutRect();
> 
> The patch deletes this check. Why isn’t this needed?
the m_owningLayer of the RenderLayerBackig is always composited so that check should always evaluate to true, but I'll check with smfr before landing.

[Build Bot]

Comment on attachment 234820 [details]
Patch

Attachment 234820 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6458563052437504

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 234822 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[alan]

(In reply to comment #5)
> (From update of attachment 234820 [details])
> Attachment 234820 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/6458563052437504
> 
> New failing tests:
> media/W3C/video/networkState/networkState_during_loadstart.html

seems unrelated.

[Build Bot]

Comment on attachment 234820 [details]
Patch

Attachment 234820 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6541610808508416

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 234825 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[alan]

Created attachment 234864 [details]
Patch

[alan]

Comment on attachment 234864 [details]
Patch

EWS testing

[WebKit Commit Bot]

Comment on attachment 234864 [details]
Patch

Clearing flags on attachment: 234864

Committed r171073: <http://trac.webkit.org/changeset/171073>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.