Bug 134856

Summary:

[iOS] update control type when playback state changes

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, commit-queue, dino, glenn, jer.noble, philipj, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Description Eric Carlson 2014-07-12 11:16:34 PDT

The iOS media controls potentially have two modes: a big play button that sits in the middle of the <video> and inline controls. On devices that allow inline playback, the big play button is always shown and the inline controller is supposed to show once playback begins. 

Currently the control type is only checked/changed when readyState changes, so it is possible to get stuck with the overlay button if readyState reaches loadeddata before playback begins.

Comment 1 Eric Carlson 2014-07-12 11:42:01 PDT

Created attachment 234805 [details]
Proposed patch

I wasn't able to come up with a reliable test because the problem this patch fixes is extremely timing dependent.

Comment 2 WebKit Commit Bot 2014-07-12 15:15:06 PDT

Comment on attachment 234805 [details]
Proposed patch

Clearing flags on attachment: 234805

Committed r171032: <http://trac.webkit.org/changeset/171032>

Comment 3 WebKit Commit Bot 2014-07-12 15:15:09 PDT

All reviewed patches have been landed.  Closing bug.