Bug 134852

Summary:

[MSE] http/tests/media/media-source/mediasource-duration.html is failing.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, calvaris, cgarcia, clopez, commit-queue, eric.carlson, esprehn+autocc, glenn, gustavo, gyuyoung.kim, ltilve, menard, mrobinson, philipj, pnormand, sergio, vjaquez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	eric.carlson: review+

Jer Noble

Reported 2014-07-11 23:25:33 PDT

[MSE] http/tests/media/media-source/mediasource-duration.html is failing.

Attachments
Patch (213.44 KB, patch) 2014-07-12 00:15 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (217.62 KB, patch) 2014-07-12 08:16 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (61.21 KB, patch) 2014-07-12 08:21 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (217.69 KB, patch) 2014-07-12 08:26 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (217.61 KB, patch) 2014-07-12 08:33 PDT, Jer Noble	eric.carlson: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2014-07-12 00:15:31 PDT

Created attachment 234796 [details] Patch

WebKit Commit Bot

Comment 2 2014-07-12 00:17:21 PDT

Attachment 234796 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jer Noble

Comment 3 2014-07-12 08:16:04 PDT

Created attachment 234800 [details] Patch

Jer Noble

Comment 4 2014-07-12 08:16:42 PDT

Fixed the gtk-wk2 EWS.

WebKit Commit Bot

Comment 5 2014-07-12 08:16:59 PDT

Attachment 234800 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jer Noble

Comment 6 2014-07-12 08:21:14 PDT

Created attachment 234801 [details] Patch

WebKit Commit Bot

Comment 7 2014-07-12 08:23:50 PDT

Attachment 234801 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jer Noble

Comment 8 2014-07-12 08:26:56 PDT

Created attachment 234802 [details] Patch

WebKit Commit Bot

Comment 9 2014-07-12 08:28:28 PDT

Attachment 234802 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jer Noble

Comment 10 2014-07-12 08:33:33 PDT

Created attachment 234803 [details] Patch

WebKit Commit Bot

Comment 11 2014-07-12 08:35:20 PDT

Attachment 234803 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 12 2014-07-12 09:19:48 PDT

Comment on attachment 234803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234803&action=review > Source/WebCore/ChangeLog:131 > + (WebCore::HTMLMediaElement::parseAttribute): Do not issue an additional 'timeupdate' event > + after finishSeek() issues one of its own. svn-create-patch fail: parseAttribute -> mediaPlayerTimeChanged

Jer Noble

Comment 13 2014-07-12 15:40:36 PDT

Committed r171033: <http://trac.webkit.org/changeset/171033>

Carlos Alberto Lopez Perez

Comment 14 2014-07-16 08:52:33 PDT

This has caused the tests media/media-controls-invalid-url.html and media/video-fast-seek.html fail on the GTK port. Reported here: https://bugs.webkit.org/show_bug.cgi?id=134976

Note You need to log in before you can comment on or make changes to this bug.