| Summary: | [MSE] http/tests/media/media-source/mediasource-duration.html is failing. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | agomez, calvaris, cgarcia, clopez, commit-queue, eric.carlson, esprehn+autocc, glenn, gustavo, gyuyoung.kim, ltilve, menard, mrobinson, philipj, pnormand, sergio, vjaquez | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Jer Noble
2014-07-11 23:25:33 PDT
Created attachment 234796 [details]
Patch
Attachment 234796 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 234800 [details]
Patch
Fixed the gtk-wk2 EWS. Attachment 234800 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 234801 [details]
Patch
Attachment 234801 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 234802 [details]
Patch
Attachment 234802 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 234803 [details]
Patch
Attachment 234803 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 234803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234803&action=review > Source/WebCore/ChangeLog:131 > + (WebCore::HTMLMediaElement::parseAttribute): Do not issue an additional 'timeupdate' event > + after finishSeek() issues one of its own. svn-create-patch fail: parseAttribute -> mediaPlayerTimeChanged Committed r171033: <http://trac.webkit.org/changeset/171033> This has caused the tests media/media-controls-invalid-url.html and media/video-fast-seek.html fail on the GTK port. Reported here: https://bugs.webkit.org/show_bug.cgi?id=134976 |