Bug 134845

Summary: REGRESSION (r169735): Web Inspector: Timeline tree outline missing data until collapse-expand
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, graouts, joepeck, rniwa, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Bug
none
Fixed after collapse and expand
none
Patch
none
Patch
none
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 none

Timothy Hatcher
Reported 2014-07-11 14:52:55 PDT
Loading http://www.webkit.org/misc/drosera/ with the Inspector open will record a timeline. The Timeline is missing the nested timeline data for the main resource. You need to collapse and expand the main resource to see the children rows. See screenshots.
Attachments
Bug (50.41 KB, image/png)
2014-07-11 14:53 PDT, Timothy Hatcher 		no flags
Details
Fixed after collapse and expand (63.46 KB, image/png)
2014-07-11 14:53 PDT, Timothy Hatcher 		no flags
Details
Patch (2.80 KB, patch)
2014-07-17 14:22 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (5.03 KB, patch)
2014-07-17 22:51 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (519.66 KB, application/zip)
2014-07-18 02:55 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-07-11 14:53:08 PDT
<rdar://problem/17646599>
Timothy Hatcher
Comment 2 2014-07-11 14:53:18 PDT
Created attachment 234782 [details] Bug
Timothy Hatcher
Comment 3 2014-07-11 14:53:38 PDT
Created attachment 234783 [details] Fixed after collapse and expand
Timothy Hatcher
Comment 4 2014-07-11 15:02:24 PDT
Caused by https://trac.webkit.org/changeset/169735.
Timothy Hatcher
Comment 5 2014-07-11 15:57:59 PDT
Reverting r169735 fixes this. We will then need to find another fix for bug 129696.
Timothy Hatcher
Comment 6 2014-07-17 14:20:13 PDT
Reverting r169735 does not bring the other bug back. I suspect it was fixed by subsequent changes in that area (r170416 & r170389).
Timothy Hatcher
Comment 7 2014-07-17 14:22:04 PDT
Created attachment 235092 [details] Patch
Timothy Hatcher
Comment 8 2014-07-17 14:27:56 PDT
Comment on attachment 235092 [details] Patch This needs more work. Finally reproduced the issue correctly.
Timothy Hatcher
Comment 9 2014-07-17 22:51:50 PDT
Created attachment 235111 [details] Patch
Build Bot
Comment 10 2014-07-18 02:54:57 PDT
Comment on attachment 235111 [details] Patch Attachment 235111 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6285852082700288 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html media/track/track-long-word-container-sizing.html
Build Bot
Comment 11 2014-07-18 02:55:00 PDT
Created attachment 235120 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Timothy Hatcher
Comment 12 2014-07-18 09:32:36 PDT
Comment on attachment 235111 [details] Patch Unrelated test failures. Marking cq? again.
Joseph Pecoraro
Comment 13 2014-07-18 10:48:51 PDT
Comment on attachment 235111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235111&action=review r=me > Source/WebInspectorUI/ChangeLog:11 > + (WebInspector.DOMTreeElement.prototype.adjustCollapsedRange): Use button isteand of assuming Typo: isteand => instead
WebKit Commit Bot
Comment 14 2014-07-18 11:21:17 PDT
Comment on attachment 235111 [details] Patch Clearing flags on attachment: 235111 Committed r171227: <http://trac.webkit.org/changeset/171227>
WebKit Commit Bot
Comment 15 2014-07-18 11:21:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.