Summary: | REGRESSION (r169735): Web Inspector: Timeline tree outline missing data until collapse-expand | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||||||
Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, graouts, joepeck, rniwa, timothy, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
Timothy Hatcher
2014-07-11 14:52:55 PDT
Created attachment 234782 [details]
Bug
Created attachment 234783 [details]
Fixed after collapse and expand
Caused by https://trac.webkit.org/changeset/169735. Reverting r169735 fixes this. We will then need to find another fix for bug 129696. Reverting r169735 does not bring the other bug back. I suspect it was fixed by subsequent changes in that area (r170416 & r170389). Created attachment 235092 [details]
Patch
Comment on attachment 235092 [details]
Patch
This needs more work. Finally reproduced the issue correctly.
Created attachment 235111 [details]
Patch
Comment on attachment 235111 [details] Patch Attachment 235111 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6285852082700288 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html media/track/track-long-word-container-sizing.html Created attachment 235120 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 235111 [details]
Patch
Unrelated test failures. Marking cq? again.
Comment on attachment 235111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235111&action=review r=me > Source/WebInspectorUI/ChangeLog:11 > + (WebInspector.DOMTreeElement.prototype.adjustCollapsedRange): Use button isteand of assuming Typo: isteand => instead Comment on attachment 235111 [details] Patch Clearing flags on attachment: 235111 Committed r171227: <http://trac.webkit.org/changeset/171227> All reviewed patches have been landed. Closing bug. |