| Summary: | [CSS Grid Layout] Remove stack from grid-auto-flow syntax | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||
| Component: | Layout and Rendering | Assignee: | Manuel Rego Casasnovas <rego> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, jfernandez, svillar, syoichi | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 134544 | ||||||||||
| Bug Blocks: | 103316 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Manuel Rego Casasnovas
2014-07-11 13:44:00 PDT
After some discussion in the CSS WG, in the last update of the spec "stack" mode has been dropped: http://dev.w3.org/csswg/css-grid/#propdef-grid-auto-flow We need to update the syntax again to remove "stack" option and also remove the pending FIXMEs from the source code. Created attachment 243760 [details]
Patch
Comment on attachment 243760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243760&action=review Nice! I never understood the purpose of stack actually. > Source/WebCore/rendering/style/GridResolvedPosition.cpp:141 > } Nit: we can move the comment above the if and remove the curly braces. Created attachment 243883 [details]
Patch for landing
Created attachment 243884 [details]
Patch for landing (adding reviewer)
Comment on attachment 243884 [details] Patch for landing (adding reviewer) Clearing flags on attachment: 243884 Committed r177858: <http://trac.webkit.org/changeset/177858> All reviewed patches have been landed. Closing bug. |