Bug 134759 – [EFL][WK2] Add new Public API in ewk_download_job.h to get length of the data already downloaded

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Shivakumar J M]

Currently there is no direct API in ewk_download_job.h to get length of the data already downloaded. so add new API in ewk_download_job.h.

[Shivakumar J M]

Created attachment 234627 [details]
Patch

Add new API in ewk_download_job.h to get length of the data already downloaded.

[Gyuyoung Kim]

Comment on attachment 234627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234627&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_download_job.h:193
> +EAPI uint64_t ewk_download_get_received_data_length(const Ewk_Download_Job *download);

Missing API test for this new API.

And also, looks wrong API naming. Generally verb is placed at the end of function name in EFL function.

For example,
ewk_download_received_data_length_get()

[Shivakumar J M]

Created attachment 234628 [details]
Patch-Updated-Review

Updated the Patch with review comments

[Gyuyoung Kim]

(In reply to comment #0)
> Currently there is no direct API in ewk_download_job.h to get length of the data already downloaded. so add new API in ewk_download_job.h.

Could you explain why we have to add this API ? I wonder when application needs to know downloaded data length.

[Shivakumar J M]

(In reply to comment #4)
> (In reply to comment #0)
> > Currently there is no direct API in ewk_download_job.h to get length of the data already downloaded. so add new API in ewk_download_job.h.
> 
> Could you explain why we have to add this API ? I wonder when application needs to know downloaded data length.

I feel these will be useful in multiple download and also for download manger kind of applications.

[Gyuyoung Kim]

Comment on attachment 234628 [details]
Patch-Updated-Review

View in context: https://bugs.webkit.org/attachment.cgi?id=234628&action=review

LGTM except for minor nits.

> Source/WebKit2/UIProcess/API/efl/ewk_download_job.h:189
> + * @param download a #Ewk_Download_Job to query.

We haven't add period at @param and @return.

> Source/WebKit2/UIProcess/API/efl/ewk_download_job.h:191
> + * @return the length of the data already downloaded.

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_download_job.h:193
> +EAPI uint64_t ewk_download_job_received_data_length_get(const Ewk_Download_Job *download);

Isn't "data_size" more proper for this API ?

> Source/WebKit2/UIProcess/API/efl/ewk_download_job_private.h:71
> +    uint64_t receivedData() const;

receivedDataSize() ?

[Shivakumar J M]

Created attachment 234684 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 234684 [details]
Patch for landing

Clearing flags on attachment: 234684

Committed r170951: <http://trac.webkit.org/changeset/170951>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.