Summary: | Get rid of WebFontCache | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
Component: | Layout and Rendering | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, enrica, hyatt, jonlee, mitz, simon.fraser, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Myles C. Maxfield
2014-07-08 22:08:34 PDT
Created attachment 235378 [details]
Patch
Attachment 235378 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/mac/FontCacheMac.mm:32: Found header this file implements after a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Style is a false negative. Comment on attachment 235378 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235378&action=review > Source/WebCore/platform/graphics/mac/FontCacheMac.mm:213 > +#pragma clang diagnostic ignored "-Wglobal-constructors" WebCore is not allowed to include global constructors, which is why we have enabled this warning. Created attachment 241635 [details]
Patch
Comment on attachment 241635 [details]
Patch
r=me
|