Bug 134752

Summary: Get rid of WebFontCache
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: Layout and RenderingAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, enrica, hyatt, jonlee, mitz, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch hyatt: review+

Myles C. Maxfield
Reported 2014-07-08 22:08:34 PDT
No reason it should be around
Attachments
Patch (34.02 KB, patch)
2014-07-23 14:24 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (44.54 KB, patch)
2014-11-14 15:49 PST, Myles C. Maxfield 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-07-23 14:24:05 PDT
Created attachment 235378 [details] Patch
WebKit Commit Bot
Comment 2 2014-07-23 14:25:16 PDT
Attachment 235378 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/mac/FontCacheMac.mm:32: Found header this file implements after a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Myles C. Maxfield
Comment 3 2014-07-23 14:27:47 PDT
Style is a false negative.
mitz
Comment 4 2014-11-11 15:18:23 PST
Comment on attachment 235378 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235378&action=review > Source/WebCore/platform/graphics/mac/FontCacheMac.mm:213 > +#pragma clang diagnostic ignored "-Wglobal-constructors" WebCore is not allowed to include global constructors, which is why we have enabled this warning.
Radar WebKit Bug Importer
Comment 5 2014-11-11 15:18:56 PST
<rdar://problem/18947048>
Myles C. Maxfield
Comment 6 2014-11-14 15:49:18 PST
Created attachment 241635 [details] Patch
Dave Hyatt
Comment 7 2014-11-14 15:57:19 PST
Comment on attachment 241635 [details] Patch r=me
Myles C. Maxfield
Comment 8 2014-11-14 16:03:31 PST
https://trac.webkit.org/r176146
Note You need to log in before you can comment on or make changes to this bug.