Bug 134750

Summary: [EFL] Enable ENCRYPTED_MEDIA_V2 to play encrypted media contents.
Product: WebKit Reporter: Sun-woo Nam <sunny.nam>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, calvaris, commit-queue, eric.carlson, glenn, gyuyoung.kim, jer.noble, lucas.de.marchi, philipj, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sun-woo Nam
Reported 2014-07-08 19:23:07 PDT
Webkit needs to play encrypted media contents when media player is played by Media source extensions and normal video procedure. And when turning ENABLE_ENCRYPTED_MEDIA_V2 on, the build break occurs. Some source files need to be included in CMakeLists.txt file for build and wrapped the included header file which is built only on mac and wince.
Attachments
Patch (4.48 KB, patch)
2014-07-08 19:26 PDT, Sun-woo Nam 		no flags
DetailsFormatted DiffDiff
Patch (3.77 KB, patch)
2014-07-08 19:29 PDT, Sun-woo Nam 		no flags
DetailsFormatted DiffDiff
Patch (3.77 KB, patch)
2014-07-08 21:07 PDT, Sun-woo Nam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sun-woo Nam
Comment 1 2014-07-08 19:26:33 PDT
Created attachment 234611 [details] Patch
Sun-woo Nam
Comment 2 2014-07-08 19:29:45 PDT
Created attachment 234612 [details] Patch
Gyuyoung Kim
Comment 3 2014-07-08 20:59:50 PDT
Comment on attachment 234612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234612&action=review > Source/WebCore/ChangeLog:8 > + When turning ENABLE_ENCRYPTED_MEDIA_V2 on, the build break occurs. the build break -> a build break or build break ? > Source/WebCore/Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp:35 > #include "MediaPlayer.h" Add an empty line before #if PLATFORM(IOS) || OS(WINCE)
Sun-woo Nam
Comment 4 2014-07-08 21:07:04 PDT
Created attachment 234616 [details] Patch
Gyuyoung Kim
Comment 5 2014-07-08 21:09:20 PDT
Comment on attachment 234616 [details] Patch LGTM. Please land after passing efl ews.
WebKit Commit Bot
Comment 6 2014-07-08 22:57:07 PDT
Comment on attachment 234616 [details] Patch Clearing flags on attachment: 234616 Committed r170910: <http://trac.webkit.org/changeset/170910>
WebKit Commit Bot
Comment 7 2014-07-08 22:57:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.