Bug 134741

Summary: Revert r170413 and r170390
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, jonlee, kondapallykalyan, pdr, rniwa, schenney, sergio, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
none
Patch none

Myles C. Maxfield
Reported 2014-07-08 13:09:55 PDT
Revert r170413 and r170390
Attachments
Patch (90.98 KB, patch)
2014-07-08 13:12 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (670.65 KB, application/zip)
2014-07-08 15:09 PDT, Build Bot 		no flags
Details
Patch (90.03 KB, patch)
2014-07-09 08:04 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-07-08 13:12:29 PDT
Created attachment 234585 [details] Patch
WebKit Commit Bot
Comment 2 2014-07-08 13:15:13 PDT
Attachment 234585 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:106: The parameter name "const" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.
zalan
Comment 3 2014-07-08 13:22:13 PDT
is there a list somewhere with the sites/use cases that the original changeset broke?
Benjamin Poulain
Comment 4 2014-07-08 13:51:35 PDT
Comment on attachment 234585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234585&action=review > Source/WebCore/rendering/InlineTextBox.cpp:1409 > +TextRun InlineTextBox::constructTextRun(const RenderStyle& style, const Font& font, String string, int maximumLength, String* hyphenatedStringBuffer) const > { > - unsigned length = string.length(); > + int length = string.length(); This is suspicious, can you explain this?
Jon Lee
Comment 5 2014-07-08 15:04:35 PDT
<rdar://problem/17571191>
Build Bot
Comment 6 2014-07-08 15:09:16 PDT
Comment on attachment 234585 [details] Patch Attachment 234585 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6450686417960960 New failing tests: media/W3C/video/src/src_reflects_attribute_not_source_elements.html
Build Bot
Comment 7 2014-07-08 15:09:20 PDT
Created attachment 234599 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Myles C. Maxfield
Comment 8 2014-07-09 08:04:03 PDT
Created attachment 234640 [details] Patch
WebKit Commit Bot
Comment 9 2014-07-09 08:05:18 PDT
Attachment 234640 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:106: The parameter name "const" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.
Myles C. Maxfield
Comment 10 2014-07-09 10:22:36 PDT
looks like efl-wk2 was a false negative
WebKit Commit Bot
Comment 11 2014-07-09 18:43:05 PDT
Comment on attachment 234640 [details] Patch Clearing flags on attachment: 234640 Committed r170947: <http://trac.webkit.org/changeset/170947>
WebKit Commit Bot
Comment 12 2014-07-09 18:43:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.