Summary: | Revert r170413 and r170390 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||
Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, buildbot, commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, jonlee, kondapallykalyan, pdr, rniwa, schenney, sergio, webkit-bug-importer, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Myles C. Maxfield
2014-07-08 13:09:55 PDT
Created attachment 234585 [details]
Patch
Attachment 234585 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:106: The parameter name "const" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 37 files
If any of these errors are false positives, please file a bug against check-webkit-style.
is there a list somewhere with the sites/use cases that the original changeset broke? Comment on attachment 234585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234585&action=review > Source/WebCore/rendering/InlineTextBox.cpp:1409 > +TextRun InlineTextBox::constructTextRun(const RenderStyle& style, const Font& font, String string, int maximumLength, String* hyphenatedStringBuffer) const > { > - unsigned length = string.length(); > + int length = string.length(); This is suspicious, can you explain this? Comment on attachment 234585 [details] Patch Attachment 234585 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6450686417960960 New failing tests: media/W3C/video/src/src_reflects_attribute_not_source_elements.html Created attachment 234599 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 234640 [details]
Patch
Attachment 234640 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:106: The parameter name "const" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 37 files
If any of these errors are false positives, please file a bug against check-webkit-style.
looks like efl-wk2 was a false negative Comment on attachment 234640 [details] Patch Clearing flags on attachment: 234640 Committed r170947: <http://trac.webkit.org/changeset/170947> All reviewed patches have been landed. Closing bug. |