Bug 134738

Summary:

[GTK] Add support for user scripts to WebKitUserContentManager

Product:

WebKit

Reporter:

Adrian Perez <aperez>

Component:

WebKitGTK

Assignee:

Adrian Perez <aperez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, bunhere, cdumez, cgarcia, commit-queue, gustavo, gyuyoung.kim, mrobinson, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	cgarcia: review+, cgarcia: commit-queue-
Patch for landing	none

Adrian Perez

Reported 2014-07-08 12:30:15 PDT

This would be similar as for user style sheets from bug #34551 but in this case for user scripts.

Attachments
Patch (22.08 KB, patch) 2014-07-08 12:46 PDT, Adrian Perez	no flags	Details Formatted Diff Diff
Patch (21.97 KB, patch) 2014-07-09 11:44 PDT, Adrian Perez	cgarcia: review+ cgarcia: commit-queue-	Details Formatted Diff Diff
Patch for landing (21.41 KB, patch) 2014-08-06 06:45 PDT, Carlos Garcia Campos	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adrian Perez

Comment 1 2014-07-08 12:46:24 PDT

Created attachment 234583 [details] Patch

WebKit Commit Bot

Comment 2 2014-07-08 12:47:48 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Adrian Perez

Comment 3 2014-07-09 11:44:14 PDT

Created attachment 234648 [details] Patch

Carlos Garcia Campos

Comment 4 2014-08-03 03:38:35 PDT

Comment on attachment 234648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234648&action=review The API looks good to me, it's the equivalent to the style sheets API. > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:133 > - removeOldInjectedStyleSheetsAndResetLists(test->m_userContentManager.get(), whitelist, blacklist); > + removeOldInjectedContentAndResetLists(test->m_userContentManager.get(), whitelist, blacklist); Why do we need to remove also the scripts? > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:135 > + // Without a whitelist or a blacklist all URLs should have the injected style sheet. Looks like this method is for testing style sheets (testUserContentManagerInjectedStyleSheet), but it's testing user scripts instead. > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:171 > +static void testUserContentManagerInjectedScript(UserContentManagerTest* test, gconstpointer) And here you are testing the style sheets . . .

Gustavo Noronha (kov)

Comment 5 2014-08-06 05:23:07 PDT

Comment on attachment 234648 [details] Patch API looks good to me as well =)

Carlos Garcia Campos

Comment 6 2014-08-06 06:45:37 PDT

Created attachment 236098 [details] Patch for landing

WebKit Commit Bot

Comment 7 2014-08-06 08:07:27 PDT

Comment on attachment 236098 [details] Patch for landing Clearing flags on attachment: 236098 Committed r172147: <http://trac.webkit.org/changeset/172147>

WebKit Commit Bot

Comment 8 2014-08-06 08:07:33 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.