Bug 134735 – [GTK] Implement webkit_web_view_load_bytes() in WebKit2

• Component: WebKit2
• Status: RESOLVED FIXED

[Gergely Polonkai]

It would be nice to have the old webkit_web_view_load_string() function in the WebKit2 API, or provide a way to simulate it.

[Carlos Garcia Campos]

load_string() like in webkit1 limits the API to null terminated array of characters, so in this case I would use webkit_web_view_load_bytes() that receives a GBytes. That way we can take a reference and create an API::Data object without duplicating the memory.

[Gergely Polonkai]

How about (for 1.x compatibility reasons) implementing both? _load_string() may internally convert the null-terminated strings into GBytes and call _load_bytes() maybe. I don’t know how hard it would be, even navigating the sources is hard for me as a webkit newbie…

[Carlos Garcia Campos]

Created attachment 234704 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

(In reply to comment #2)
> How about (for 1.x compatibility reasons) implementing both? _load_string() may internally convert the null-terminated strings into GBytes and call _load_bytes() maybe. I don’t know how hard it would be, even navigating the sources is hard for me as a webkit newbie…

I think load_string is a confusing name in any case, so in case of adding a new (convenient) API to load a const char, it would be load_data that receives const char + data length. But I think it's very easy for users to simply create a GBytes.

[Gustavo Noronha (kov)]

I agree, wonder how that impacts bindings though, does anyone know if it can be made idiomatic for js and python?

[Gustavo Noronha (kov)]

Comment on attachment 234704 [details]
Patch

The API looks good to me, fwiw.

[Sergio Villar Senin]

Comment on attachment 234704 [details]
Patch

The API looks fine to me too.

[Carlos Garcia Campos]

Committed r171740: <http://trac.webkit.org/changeset/171740>

[Tim Horton]

Comment on attachment 234704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234704&action=review

> Source/WebKit2/ChangeLog:9
> +        random data in the web view using the given MIME-Type, encoding

Hopefully the data isn't random. Arbitrary?

[Carlos Garcia Campos]

(In reply to comment #10)
> (From update of attachment 234704 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234704&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        random data in the web view using the given MIME-Type, encoding
> 
> Hopefully the data isn't random. Arbitrary?

Oops, yes, you are right, bad english translation in my head.