Bug 134709

Summary: Remove WebBackForwardListItems when their owning page goes away
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, mitz, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch mitz: review+

Tim Horton
Reported 2014-07-07 18:54:57 PDT
Currently, WebProcessProxy holds on to them even after the WebPageProxy disappears.
Attachments
patch (15.73 KB, patch)
2014-07-08 13:37 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
patch (14.42 KB, patch)
2014-07-08 15:48 PDT, Tim Horton 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-07-07 18:55:19 PDT
<rdar://problem/17584645>
Tim Horton
Comment 2 2014-07-08 13:37:22 PDT
Created attachment 234591 [details] patch
Tim Horton
Comment 3 2014-07-08 15:48:06 PDT
Created attachment 234602 [details] patch
mitz
Comment 4 2014-07-08 15:55:28 PDT
Comment on attachment 234602 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=234602&action=review > Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:107 > + ItemAndPageID ids; > + ids.itemID = itemID; > + ids.pageID = pageID; > + > + historyItemToIDMap().set(item, ids); Isn’t there a way to do this without the named variable? > Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:166 > + historyItemToIDMap().set(item, ids); Ditto.
Tim Horton
Comment 5 2014-07-08 16:18:06 PDT
http://trac.webkit.org/changeset/170902
Note You need to log in before you can comment on or make changes to this bug.