Bug 134709

Summary:

Remove WebBackForwardListItems when their owning page goes away

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

WebKit2

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, mitz, sam, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	mitz: review+

Description Tim Horton 2014-07-07 18:54:57 PDT

Currently, WebProcessProxy holds on to them even after the WebPageProxy disappears.

Comment 1 Radar WebKit Bug Importer 2014-07-07 18:55:19 PDT

<rdar://problem/17584645>

Comment 2 Tim Horton 2014-07-08 13:37:22 PDT

Created attachment 234591 [details]
patch

Comment 3 Tim Horton 2014-07-08 15:48:06 PDT

Created attachment 234602 [details]
patch

Comment 4 mitz 2014-07-08 15:55:28 PDT

Comment on attachment 234602 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234602&action=review

> Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:107
> +    ItemAndPageID ids;
> +    ids.itemID = itemID;
> +    ids.pageID = pageID;
> +    
> +    historyItemToIDMap().set(item, ids);

Isn’t there a way to do this without the named variable?

> Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:166
> +    historyItemToIDMap().set(item, ids);

Ditto.

Comment 5 Tim Horton 2014-07-08 16:18:06 PDT

http://trac.webkit.org/changeset/170902