Summary: | Web Inspector: CSS style declaration editor should ignore empty lines when determining prefix whitespace | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Wells <jonowells> | ||||
Component: | Web Inspector | Assignee: | Jonathan Wells <jonowells> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Jonathan Wells
2014-07-07 16:58:37 PDT
Created attachment 234527 [details]
[PATCH] Attempted fix.
Comment on attachment 234527 [details]
[PATCH] Attempted fix.
Awesome. r=me
Comment on attachment 234527 [details] [PATCH] Attempted fix. Clearing flags on attachment: 234527 Committed r170868: <http://trac.webkit.org/changeset/170868> All reviewed patches have been landed. Closing bug. Comment on attachment 234527 [details]
[PATCH] Attempted fix.
Nice fix! We will likely add the space o the empty line in _formattedContent before committing the change. We likely want to only do that for lines with content to prevent unneeded whitespace. Not critical though.
|