Bug 134689

Summary: Web Inspector: Uncaught Exception debugging iOS 7 NetworkAgent.loadResource is unavailable
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-07-07 13:07:56 PDT
undefined is not a function (evaluating 'NetworkAgent.loadResource(frameIdentifier,sourceMapURL,sourceMapLoaded.bind(this))') We should feature check the existence of this function in the two places it is used.
Attachments
[PATCH] Proposed Fix (2.47 KB, patch)
2014-07-07 14:34 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-07-07 13:08:12 PDT
<rdar://problem/17578914>
Joseph Pecoraro
Comment 2 2014-07-07 14:03:44 PDT
I'll look into this.
Joseph Pecoraro
Comment 3 2014-07-07 14:34:22 PDT
Created attachment 234511 [details] [PATCH] Proposed Fix
Darin Adler
Comment 4 2014-07-07 16:13:05 PDT
Comment on attachment 234511 [details] [PATCH] Proposed Fix Might be good to add a comment explaining this is needed to target older versions so it’s not just deleted later.
WebKit Commit Bot
Comment 5 2014-07-07 16:45:28 PDT
Comment on attachment 234511 [details] [PATCH] Proposed Fix Clearing flags on attachment: 234511 Committed r170863: <http://trac.webkit.org/changeset/170863>
WebKit Commit Bot
Comment 6 2014-07-07 16:45:30 PDT
All reviewed patches have been landed. Closing bug.
Timothy Hatcher
Comment 7 2014-07-08 12:17:56 PDT
We do typically add // COMPATIBILITY (iOS 7): ... comments for things like this. However, we have other places where we feature check without a comment (mainly for JSContext protocol omissions).
Joseph Pecoraro
Comment 8 2014-07-08 14:15:00 PDT
(In reply to comment #7) > We do typically add // COMPATIBILITY (iOS 7): ... comments for things like this. However, we have other places where we feature check without a comment (mainly for JSContext protocol omissions). Yep, that is exactly why I left it off here. We will want to fix this eventually so we get SourceMap support debugging JSContext scripts.
Note You need to log in before you can comment on or make changes to this bug.