Bug 134668

Summary:

LinkBuffer should not keep a reference to the MacroAssembler

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Benjamin Poulain 2014-07-06 16:44:26 PDT

LinkBuffer should not keep a reference to the MacroAssembler

Comment 1 Benjamin Poulain 2014-07-06 16:51:16 PDT

Created attachment 234469 [details]
Patch

Comment 2 Geoffrey Garen 2014-07-07 11:15:03 PDT

Comment on attachment 234469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234469&action=review

r=me

Please fix Windows build failure if it is real.

> Source/JavaScriptCore/ChangeLog:9
> +        When that happen, the pointer m_assembler points to released memory. That was not causing

"happens"

Comment 3 Benjamin Poulain 2014-07-07 13:18:40 PDT

Created attachment 234505 [details]
Patch

Comment 4 Benjamin Poulain 2014-07-07 15:13:50 PDT

Created attachment 234517 [details]
Patch

Comment 5 Benjamin Poulain 2014-07-07 21:23:59 PDT

Committed r170876: <http://trac.webkit.org/changeset/170876>