Bug 134662

Summary: CSS JIT: Ensure resolvingMode size is 1 byte
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: CSSAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, benjamin, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kangil.han, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2014-07-06 05:17:04 PDT
We use branch8 in jumpIfNotResolvingStyle. However, sizeof(SelectorChecker::Mode) is 4. So it works only in little endianess environment.
Attachments
Patch (22.74 KB, patch)
2014-07-06 06:56 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2014-07-06 06:56:27 PDT
Created attachment 234457 [details] Patch
Yusuke Suzuki
Comment 2 2014-07-06 07:02:59 PDT
Comment on attachment 234457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234457&action=review Added comments. > Source/WebCore/css/SelectorChecker.h:52 > + }; Using C++11 enum class to guarantee sizeof(Mode) is 1 byte. > Source/WebCore/cssjit/SelectorCompiler.cpp:1475 > + static_assert(sizeof(SelectorChecker::Mode) == 1, "We generate a byte load/test for the SelectorChecker::Mode."); Guaranteed sizeof(SelectorChecker::Mode) == 1 by using static_assert.
Benjamin Poulain
Comment 3 2014-07-06 14:35:42 PDT
Comment on attachment 234457 [details] Patch Good catch!
Yusuke Suzuki
Comment 4 2014-07-06 18:18:56 PDT
Comment on attachment 234457 [details] Patch Clearing flags on attachment: 234457 Committed r170832: <http://trac.webkit.org/changeset/170832>
Yusuke Suzuki
Comment 5 2014-07-06 18:19:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.