Bug 134658

Summary:

[iOS] MediaDocument should set a viewport

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zalan: review+

Description Dean Jackson 2014-07-05 16:56:15 PDT

[iOS] MediaDocument should set a viewport

Comment 1 Dean Jackson 2014-07-05 16:58:06 PDT

Created attachment 234450 [details]
Patch

Comment 2 Dean Jackson 2014-07-05 17:03:54 PDT

Committed r170827: <http://trac.webkit.org/changeset/170827>

Comment 3 Darin Adler 2014-07-05 19:49:50 PDT

Comment on attachment 234450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234450&action=review

> Source/WebCore/html/MediaDocument.cpp:86
> +    rootElement->appendChild(headElement, IGNORE_EXCEPTION);

Should be headElement.release().

> Source/WebCore/html/MediaDocument.cpp:91
> +    headElement->appendChild(metaElement, IGNORE_EXCEPTION);

Should be metaElement.release().