Bug 134625

Summary:

[MediaStream] MediaStream.removeTrack should not check for active state.

Product:

WebKit

Reporter:

Seongjun Kim <isair>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, eric.carlson, glenn, gyuyoung.kim, hta, isair, jer.noble, philipj, sergio, tommyw

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
PATCH	none

Seongjun Kim

Reported 2014-07-04 02:25:54 PDT

W3C removed MediaStream state check from the removeTrack() algorithm, since February 18, 2014 For example, following code should not throw INVALID_STATE_ERR // video: MediaStream that has 1 video track. // audeo: MediaStream that has 1 audio track. video.removeTrack(video.getVideoTracks()[0]); video.removeTrack(audio.getAudioTracks()[0]); // should not throw Relative issue: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24930 Full Test: http://w3c-test.org/mediacapture-streams/stream-api/mediastream/mediastream-removetrack.html

Attachments
PATCH (1.86 KB, patch) 2014-07-04 02:56 PDT, Seongjun Kim	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Seongjun Kim

Comment 1 2014-07-04 02:56:02 PDT

Created attachment 234397 [details] PATCH First Patch. I will add a new test for this cass.

WebKit Commit Bot

Comment 2 2014-07-04 02:57:43 PDT

Attachment 234397 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.

Note You need to log in before you can comment on or make changes to this bug.