Bug 134599

Summary: [iOS] user caption preferences not applied
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, buildbot, bunhere, cdumez, commit-queue, gyuyoung.kim, rniwa, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
andersca: review-
Proposed patch.
none
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 none

Eric Carlson
Reported 2014-07-03 10:09:09 PDT
The stylesheet generated from user preferences isn't used on iOS when in WK2 mode.
Attachments
Proposed patch. (5.03 KB, patch)
2014-07-03 10:49 PDT, Eric Carlson 		andersca: review-
DetailsFormatted DiffDiff
Proposed patch. (2.82 KB, patch)
2014-07-08 13:58 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (1.02 MB, application/zip)
2014-07-08 18:15 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-07-03 10:18:02 PDT
This is fallout from r162395, because not every Page in a PageGroup uses the same UserContentController.
Eric Carlson
Comment 2 2014-07-03 10:49:48 PDT
Created attachment 234355 [details] Proposed patch.
Anders Carlsson
Comment 3 2014-07-07 11:25:31 PDT
Comment on attachment 234355 [details] Proposed patch. This needs to be done by user caption preferences, not in PageGroup. We're trying to get rid of as much of page group as possible.
Eric Carlson
Comment 4 2014-07-08 13:58:19 PDT
Created attachment 234593 [details] Proposed patch.
Build Bot
Comment 5 2014-07-08 18:15:09 PDT
Comment on attachment 234593 [details] Proposed patch. Attachment 234593 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5717610662461440 New failing tests: media/W3C/video/src/src_reflects_attribute_not_source_elements.html
Build Bot
Comment 6 2014-07-08 18:15:13 PDT
Created attachment 234610 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Sam Weinig
Comment 7 2014-07-08 20:34:40 PDT
Comment on attachment 234593 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=234593&action=review > Source/WebCore/page/CaptionUserPreferences.cpp:256 > + pageUserContentController->addUserStyleSheet(mainThreadNormalWorld(), std::move(userStyleSheet), InjectInExistingDocuments); I don't think you need to explicitly use std::move here.
Eric Carlson
Comment 8 2014-07-08 21:21:46 PDT
(In reply to comment #7) > (From update of attachment 234593 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234593&action=review > > > Source/WebCore/page/CaptionUserPreferences.cpp:256 > > + pageUserContentController->addUserStyleSheet(mainThreadNormalWorld(), std::move(userStyleSheet), InjectInExistingDocuments); > > I don't think you need to explicitly use std::move here. It looks like it is necessary.
WebKit Commit Bot
Comment 9 2014-07-08 21:53:27 PDT
Comment on attachment 234593 [details] Proposed patch. Clearing flags on attachment: 234593 Committed r170908: <http://trac.webkit.org/changeset/170908>
WebKit Commit Bot
Comment 10 2014-07-08 21:53:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.