Summary: | [GTK] [Stable] Crash in TSymbolTableLevel::~TSymbolTableLevel with GCC 4.9 | ||
---|---|---|---|
Product: | WebKit | Reporter: | Alberto Garcia <berto> |
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | cgarcia |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Alberto Garcia
2014-07-03 07:14:14 PDT
I wonder why master is not affected, though. (In reply to comment #1) > I wonder why master is not affected, though. Doesn't it have a different version of ANGLE? (In reply to comment #2) > (In reply to comment #1) > > I wonder why master is not affected, though. > > Doesn't it have a different version of ANGLE? Yes, but the fix you mention is not there. (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > I wonder why master is not affected, though. > > > > Doesn't it have a different version of ANGLE? > > Yes, but the fix you mention is not there. In master it was solved using a different fix, which seems more efficient: https://chromium.googlesource.com/angle/angle/+/adfffe4649d622bab6957972663a852f123b5ea7%5E%21/ This doesn't apply cleanly in the stable branch (there's actually lots of conflicts) but we could try to see if it's easy to backport, the changes themselves don't seem complex. Or we can just stick to the simple version in the stable branch. (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (In reply to comment #1) > > > > I wonder why master is not affected, though. > > > > > > Doesn't it have a different version of ANGLE? > > > > Yes, but the fix you mention is not there. > > In master it was solved using a different fix, which seems more efficient: > > https://chromium.googlesource.com/angle/angle/+/adfffe4649d622bab6957972663a852f123b5ea7%5E%21/ > > This doesn't apply cleanly in the stable branch (there's actually lots of conflicts) but we could try to see if it's easy to backport, the changes themselves don't seem complex. > > Or we can just stick to the simple version in the stable branch. The stable branch is using an older version of ANGLE, so let's use the simple patch for now that fixes the crashes. Commited <http://trac.webkit.org/changeset/170788> |