Bug 134587

Summary:

Broken build with build-webkit --no-video

Product:

WebKit

Reporter:

Ryuan Choi <ryuan.choi>

Component:

WebCore Misc.

Assignee:

Ryuan Choi <ryuan.choi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, bunhere, cdumez, cgarcia, cmarcelo, commit-queue, gyuyoung.kim, rakuco, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Ryuan Choi

Reported 2014-07-03 01:12:54 PDT

MEDIA_CONTROLS_SCRIPT requires VIDEO enabled. There are several error messages including below when building with -no-video (Tested on the EFL port) WebKit/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:228:1: error: control reaches end of non-void function [-Werror=return-type]

Attachments
Patch (2.66 KB, patch) 2014-07-03 01:15 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryuan Choi

Comment 1 2014-07-03 01:15:36 PDT

Created attachment 234325 [details] Patch

WebKit Commit Bot

Comment 2 2014-07-03 13:07:11 PDT

Comment on attachment 234325 [details] Patch Clearing flags on attachment: 234325 Committed r170764: <http://trac.webkit.org/changeset/170764>

WebKit Commit Bot

Comment 3 2014-07-03 13:07:18 PDT

All reviewed patches have been landed. Closing bug.

Carlos Garcia Campos

Comment 4 2014-07-10 07:54:24 PDT

Comment on attachment 234325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234325&action=review > Source/cmake/WebKitFeatures.cmake:134 > + WEBKIT_OPTION_DEPEND(ENABLE_MEDIA_CONTROLS_SCRIPT ENABLE_VIDEO) I think this is even more restrictive, MediaControlsHost uses TextTrack unconditionally, so I think ENABLE_MEDIA_CONTROLS_SCRIPT depends on ENABLE_VIDEO_TRACK

Note You need to log in before you can comment on or make changes to this bug.