Bug 134582

Summary: [iOS][WK2] Fix small bugs of dynamicViewportSizeUpdate that were causing inaccuracies in the computed target
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, sergio, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Benjamin Poulain 2014-07-02 19:13:25 PDT
[iOS][WK2] Fix small bugs of dynamicViewportSizeUpdate that were causing inaccuracies in the computed target
Comment 1 Benjamin Poulain 2014-07-02 20:22:33 PDT
Created attachment 234310 [details]
Patch
Comment 2 Tim Horton 2014-07-02 21:07:42 PDT
Comment on attachment 234310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234310&action=review

> Source/WebKit2/ChangeLog:16
> +        The first issue is that the unobscured content size was stored on integer coordinates. Because of that, it was

"on" should be "in"

> Source/WebKit2/ChangeLog:21
> +        on floating point. Since ARM64 does all those computation on double in the UIProcess, the value would be quite

computation*s* and double*s*

> Source/WebKit2/ChangeLog:27
> +        valid to have an exposed rect outside the page bounds, that areas is just under the obscured insets.

area, not areas
Comment 3 Benjamin Poulain 2014-07-03 15:12:18 PDT
Committed r170773: <http://trac.webkit.org/changeset/170773>