Bug 134578

Summary: [CMAKE] Add WEBKIT_OPTION_DEPEND macro to resolve macro dependency
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit Misc.Assignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Ryuan Choi 2014-07-02 18:09:53 PDT 
For example, VIDEO_TRACK should be disable if VIDEO is disabled.

I realized that legacy hack in OptionsEfl.cmake does not work well.

Instead, I proposed simple macro, WEBKIT_OPTION_DEPEND to solve these issues.
Comment 1 Ryuan Choi 2014-07-02 18:28:22 PDT 
Created attachment 234304 [details]
Patch
Comment 2 Gyuyoung Kim 2014-07-02 18:56:06 PDT 
Comment on attachment 234304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234304&action=review

Oh, nice. LGTM.

> Source/cmake/OptionsEfl.cmake:92
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_SLIDER ON)

Looks this is not related to this patch.
Comment 3 Gyuyoung Kim 2014-07-02 19:04:33 PDT 
Comment on attachment 234304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234304&action=review

>> Source/cmake/OptionsEfl.cmake:92
>> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_SLIDER ON)
> 
> Looks this is not related to this patch.

Ah, I misunderstood.
Comment 4 Ryuan Choi 2014-07-03 01:05:23 PDT 
Comment on attachment 234304 [details]
Patch

Clearing flags on attachment: 234304

Committed r170749: <http://trac.webkit.org/changeset/170749>
Comment 5 Ryuan Choi 2014-07-03 01:05:33 PDT 
All reviewed patches have been landed.  Closing bug.