Bug 134572

Summary:

REGRESSION(WK2): Undo does not work in text fields in Safari

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

WebKit2

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, gyuyoung.kim, sergio

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	benjamin: review+

Description Enrica Casucci 2014-07-02 17:38:23 PDT

<rdar://problem/17542238>

Comment 1 Enrica Casucci 2014-07-02 17:42:12 PDT

Created attachment 234300 [details]
Patch

Comment 2 WebKit Commit Bot 2014-07-02 17:45:15 PDT

Attachment 234300 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:65:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Benjamin Poulain 2014-07-02 17:57:10 PDT

Comment on attachment 234300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234300&action=review

Looks reasonable.

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:89
> +- (WebEditCommandProxy*)command

Space before the star.

Comment 4 Enrica Casucci 2014-07-02 18:00:04 PDT

Committed revision 170738.