Bug 134561

Summary:

REGRESSION (iOS WK2): arrow key movements don't work

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

WebKit2

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, bunhere, cdumez, commit-queue, darin, gyuyoung.kim, rniwa, sergio

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch with fixed style	benjamin: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Patch2	benjamin: review+

Description Enrica Casucci 2014-07-02 14:38:00 PDT

This can be tested using a H/W keyboard connected to an iOS device.
Type in any field on a page in Safari.
Try to move the caret with the arrow keys.

Nothing happens.

<rdar://problem/16827629>

Comment 1 Enrica Casucci 2014-07-02 14:42:29 PDT

Created attachment 234282 [details]
Patch

Comment 2 WebKit Commit Bot 2014-07-02 14:44:46 PDT

Attachment 234282 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2221:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2227:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2233:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2239:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2245:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2251:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2257:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2263:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2269:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2275:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2281:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2287:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 12 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Enrica Casucci 2014-07-02 14:58:13 PDT

Created attachment 234285 [details]
Patch with fixed style

Comment 4 Build Bot 2014-07-02 17:05:07 PDT

Comment on attachment 234285 [details]
Patch with fixed style

Attachment 234285 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5775174230081536

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

Comment 5 Build Bot 2014-07-02 17:05:11 PDT

Created attachment 234295 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 6 Enrica Casucci 2014-07-07 13:55:27 PDT

Created attachment 234509 [details]
Patch2

Comment 7 Enrica Casucci 2014-07-07 14:43:28 PDT

Committed revision 170858.