Bug 134548 – [GStreamer] MediaPlayerPrivateGStreamer.cpp fails to build when VIDEO_TRACK is enabled and using GSTREAMER_MPEGTS

• Component: Platform
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

I don't know why it doesn't happen when using build-webkit + ninja, bue when building directly with cmake I got this:

In file included from /home/cgarcia/src/git/gnome/WebKit/Source/WTF/wtf/HashMap.h:25:0,
                 from /home/cgarcia/src/git/gnome/WebKit/Source/WebCore/platform/URL.h:30,
                 from /home/cgarcia/src/git/gnome/WebKit/Source/WebCore/platform/graphics/MediaPlayer.h:36,
                 from /home/cgarcia/src/git/gnome/WebKit/Source/WebCore/platform/graphics/MediaPlayerPrivate.h:31,
                 from /home/cgarcia/src/git/gnome/WebKit/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:28,
                 from /home/cgarcia/src/git/gnome/WebKit/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:29,
                 from /home/cgarcia/src/git/gnome/WebKit/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:26:
/home/cgarcia/src/git/gnome/WebKit/Source/WTF/wtf/HashTable.h: In instantiation of 'static bool WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::isDeletedBucket(const ValueType&) [with Key = WTF::AtomicString; Value = WTF::KeyValuePair<WTF::AtomicString, WTF::RefPtr<WebCore::InbandMetadataTextTrackPrivateGStreamer> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::AtomicString, WTF::RefPtr<WebCore::InbandMetadataTextTrackPrivateGStreamer> > >; HashFunctions = WTF::AtomicStringHash; Traits = WTF::HashMap<WTF::AtomicString, WTF::RefPtr<WebCore::InbandMetadataTextTrackPrivateGStreamer> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WTF::AtomicString>; WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType = WTF::KeyValuePair<WTF::AtomicString, WTF::RefPtr<WebCore::InbandMetadataTextTrackPrivateGStreamer> >]':
/home/cgarcia/src/git/gnome/WebKit/Source/WTF/wtf/HashTable.h:1050:42:   required from 'static void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::deallocateTable(WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType*, int) [with Key = WTF::AtomicString; Value = WTF::KeyValuePair<WTF::AtomicString, WTF::RefPtr<WebCore::InbandMetadataTextTrackPrivateGStreamer> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::AtomicString, WTF::RefPtr<WebCore::InbandMetadataTextTrackPrivateGStreamer> > >; HashFunctions = WTF::AtomicStringHash; Traits = WTF::HashMap<WTF::AtomicString, WTF::RefPtr<WebCore::InbandMetadataTextTrackPrivateGStreamer> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WTF::AtomicString>; WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType = WTF::KeyValuePair<WTF::AtomicString, WTF::RefPtr<WebCore::InbandMetadataTextTrackPrivateGStreamer> >]'
/home/cgarcia/src/git/gnome/WebKit/Source/WTF/wtf/HashTable.h:353:53:   required from 'WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::~HashTable() [with Key = WTF::AtomicString; Value = WTF::KeyValuePair<WTF::AtomicString, WTF::RefPtr<WebCore::InbandMetadataTextTrackPrivateGStreamer> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::AtomicString, WTF::RefPtr<WebCore::InbandMetadataTextTrackPrivateGStreamer> > >; HashFunctions = WTF::AtomicStringHash; Traits = WTF::HashMap<WTF::AtomicString, WTF::RefPtr<WebCore::InbandMetadataTextTrackPrivateGStreamer> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WTF::AtomicString>]'
/home/cgarcia/src/git/gnome/WebKit/Source/WTF/wtf/HashMap.h:36:7:   required from here
/home/cgarcia/src/git/gnome/WebKit/Source/WTF/wtf/HashTable.h:399:121: error: 'isDeletedValue' is not a member of 'WTF::HashTraits<WTF::AtomicString>'

And a lot of other cryptic C++ errors

[Carlos Garcia Campos]

Created attachment 234267 [details]
Patch

[Carlos Garcia Campos]

Committed r170709: <http://trac.webkit.org/changeset/170709>