Bug 134542

Summary: [GTK] make dist is broken
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, bunhere, cdumez, commit-queue, gustavo, gyuyoung.kim, mrobinson, rakuco, rniwa, sergio
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 134543    
Attachments:
Description Flags
Patch
none
Updated patch
mrobinson: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 none

Carlos Garcia Campos
Reported 2014-07-02 03:42:59 PDT
The cmake target is never added because it depends on WebKit1 that is no longer in tree. The manifest contains path to WebKit documentation files that don't exist either. And the command line options used by cmake don't match the ones defines in the make-dist.py script.
Attachments
Patch (4.17 KB, patch)
2014-07-02 03:46 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (4.32 KB, patch)
2014-07-02 03:52 PDT, Carlos Garcia Campos 		mrobinson: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (622.81 KB, application/zip)
2014-07-02 04:57 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-07-02 03:46:23 PDT
Created attachment 234249 [details] Patch
Carlos Garcia Campos
Comment 2 2014-07-02 03:52:20 PDT
Created attachment 234250 [details] Updated patch Forgot to remove a couple more wk1 references from the manifest
Build Bot
Comment 3 2014-07-02 04:57:45 PDT
Comment on attachment 234250 [details] Updated patch Attachment 234250 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6613055374884864 New failing tests: media/W3C/audio/canPlayType/canPlayType_application_octet_stream_with_codecs_1.html
Build Bot
Comment 4 2014-07-02 04:57:49 PDT
Created attachment 234253 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Carlos Garcia Campos
Comment 5 2014-07-02 08:12:16 PDT
Committed r170705: <http://trac.webkit.org/changeset/170705>
Note You need to log in before you can comment on or make changes to this bug.