| Summary: | WebVTT percentage value can be a float | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||
| Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, buildbot, bunhere, calvaris, cdumez, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, rniwa, sergio | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 234197 [details]
Proposed patch.
Attachment 234197 [details] did not pass style-queue:
ERROR: Source/WebCore/html/track/VTTScanner.h:130: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 1 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 234197 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=234197&action=review r=me > Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:-507 > - client()->removeGenericCue(this, m_cues[currentCue].get()); Yay! :-) Comment on attachment 234197 [details] Proposed patch. Attachment 234197 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5244720670310400 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html Created attachment 234230 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Committed r170694: https://trac.webkit.org/r170694 |
The WebVTT says: A WebVTT percentage consists of the following components: 1. One or more ASCII digits. 2. Optionally: 1. A U+002E DOT character (.). 2. One or more ASCII digits. 3. A U+0025 PERCENT SIGN character (%). WebKit does not recognize values with a decimal point.