Bug 134511

Summary: WebVTT percentage value can be a float
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, bunhere, calvaris, cdumez, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, rniwa, sergio
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
bfulgham: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 none

Eric Carlson
Reported 2014-07-01 14:14:40 PDT
The WebVTT says: A WebVTT percentage consists of the following components: 1. One or more ASCII digits. 2. Optionally: 1. A U+002E DOT character (.). 2. One or more ASCII digits. 3. A U+0025 PERCENT SIGN character (%). WebKit does not recognize values with a decimal point.
Attachments
Proposed patch. (34.52 KB, patch)
2014-07-01 14:29 PDT, Eric Carlson 		bfulgham: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (521.97 KB, application/zip)
2014-07-01 18:42 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-07-01 14:15:32 PDT
<rdar://16764664>
Eric Carlson
Comment 2 2014-07-01 14:29:13 PDT
Created attachment 234197 [details] Proposed patch.
WebKit Commit Bot
Comment 3 2014-07-01 14:30:49 PDT
Attachment 234197 [details] did not pass style-queue: ERROR: Source/WebCore/html/track/VTTScanner.h:130: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 4 2014-07-01 16:22:53 PDT
Comment on attachment 234197 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=234197&action=review r=me > Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:-507 > - client()->removeGenericCue(this, m_cues[currentCue].get()); Yay! :-)
Build Bot
Comment 5 2014-07-01 18:42:25 PDT
Comment on attachment 234197 [details] Proposed patch. Attachment 234197 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5244720670310400 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Build Bot
Comment 6 2014-07-01 18:42:30 PDT
Created attachment 234230 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Eric Carlson
Comment 7 2014-07-01 20:37:04 PDT
Committed r170694: https://trac.webkit.org/r170694
Note You need to log in before you can comment on or make changes to this bug.