Summary: | In needs FTL implementation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matthew Mirman <mmirman> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | fpizlo, ggaren, mark.lam, mmirman, sam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Matthew Mirman
2014-07-01 13:07:02 PDT
Created attachment 234203 [details]
Added In to the FTL
For ftlopt branch.
Comment on attachment 234203 [details] Added In to the FTL View in context: https://bugs.webkit.org/attachment.cgi?id=234203&action=review Add a test for the generic In case and change the sizeOfCheckIn. Otherwise LGTM! > Source/JavaScriptCore/ftl/FTLInlineCacheSize.cpp:70 > +#if CPU(ARM64) > + return 44; // TODO: I DON'T YET KNOW WHAT TO PUT HERE > +#else > + return 32; // TODO: I DON'T YET KNOW WHAT TO PUT HERE > +#endif In general, you should put the smallest value that doesn't result in a crash. In this case it's just the size of a patchable jump, which on x86 is 5 and on ARM is 4. Created attachment 234292 [details]
Added In to the FTL
Fixed size and added that test. For ftlopt.
Comment on attachment 234292 [details]
Added In to the FTL
Nice! You should land it yourself. Also, for patches that you intend to land yourself, don't set cq to ?.
Please be sure to run the full set of regression tests on the ftlopt branch before landing this (if you haven't already). Landed in http://trac.webkit.org/changeset/170736 |