| Summary: | [iOS] languageSpecificFallbackFont() is not consistent | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bunhere, cdumez, commit-queue, darin, dino, gyuyoung.kim, jonlee, sergio, simon.fraser, thorton | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Myles C. Maxfield
2014-06-30 16:57:56 PDT
Created attachment 234121 [details]
Patch
Attachment 234121 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 234121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234121&action=review > Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:155 > + if (c < 0x1401) > + return LanguageSpecificFont::None; Looks to me like this changes behavior. The old code would return LanguageSpecificFont::Khmer for 0x1200-0x1400. Created attachment 234124 [details]
Patch
Comment on attachment 234121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234121&action=review >> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:155 >> + return LanguageSpecificFont::None; > > Looks to me like this changes behavior. The old code would return LanguageSpecificFont::Khmer for 0x1200-0x1400. Yeah, you're right. Yet another reason why we need to be consistent! Created attachment 234125 [details]
Patch
|