Summary: | WebBackForwardListItems should hold on to PageState objects | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, sergio | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2014-06-30 16:14:08 PDT
Created attachment 234111 [details]
Patch
Comment on attachment 234111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234111&action=review OK > Source/WebKit2/Shared/WebBackForwardListItem.cpp:41 > + m_pageState.mainFrameState.originalURLString = originalURL; > + m_pageState.mainFrameState.urlString = url; > + m_pageState.title = title; No constructor for PageState? Is it just a struct? > Source/WebKit2/Shared/WebBackForwardListItem.cpp:69 > + encoder << m_pageState.mainFrameState.originalURLString; > + encoder << m_pageState.mainFrameState.urlString; > + encoder << m_pageState.title; No helper function for pageState? Doesn’t have to be a member function. (In reply to comment #2) > (From update of attachment 234111 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234111&action=review > > OK > > > Source/WebKit2/Shared/WebBackForwardListItem.cpp:41 > > + m_pageState.mainFrameState.originalURLString = originalURL; > > + m_pageState.mainFrameState.urlString = url; > > + m_pageState.title = title; > > No constructor for PageState? Is it just a struct? Yes. > > > Source/WebKit2/Shared/WebBackForwardListItem.cpp:69 > > + encoder << m_pageState.mainFrameState.originalURLString; > > + encoder << m_pageState.mainFrameState.urlString; > > + encoder << m_pageState.title; > > No helper function for pageState? Doesn’t have to be a member function. This is just temporary - we don't want to encode and decode WebBackForwardListItems. Committed r170613: <http://trac.webkit.org/changeset/170613> |