| Summary: | All Indic text is rendered as boxes on iOS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bunhere, cdumez, commit-queue, darin, dino, gyuyoung.kim, jonlee, sergio, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2014-06-30 15:40:53 PDT
Created attachment 234110 [details]
Patch
Uploaded patch before I had generated all the platform-specific expected results in order to give people more reviewing time Comment on attachment 234110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234110&action=review Where’s the actual fix? It looks like it’s mixed in with many small non-behavior-changing changes, specifically changing all the <= to < in the languageSpecificFallbackFont function. Would be nice to separate those from the bug fix for clarity. It seems like you fixed more than just Indic here. I’m not sure the test sufficiently covers the changes. > LayoutTests/ChangeLog:11 > + * platform/ios-sim/fast/text/indic-expected.txt: Added. No results for any other platforms? Won’t this cause problems? Comment on attachment 234110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234110&action=review >> LayoutTests/ChangeLog:11 >> + * platform/ios-sim/fast/text/indic-expected.txt: Added. > > No results for any other platforms? Won’t this cause problems? I see you commented on this already. rs=me to land a first patch that simply changes all <= to < so we can see a rebased patch that shows only the actual changes; or you could leave all existing <= in that form and change to < in a subsequent patch Created attachment 234123 [details]
Patch
|