Bug 134455

Summary: CodeBlock::stronglyVisitWeakReferences should mark DFG::CommonData::weakStructureReferences
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, fpizlo, gyuyoung.kim, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Mark Hahnenberg
Reported 2014-06-30 14:24:54 PDT
Otherwise we get hanging pointers which can cause us to die later.
Attachments
Patch (1.35 KB, patch)
2014-06-30 14:26 PDT, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-06-30 14:26:52 PDT
Created attachment 234093 [details] Patch
Geoffrey Garen
Comment 2 2014-06-30 14:34:17 PDT
Comment on attachment 234093 [details] Patch r=me Any way to regression test this? Maybe even something that only crashes in Zombie mode?
Mark Hahnenberg
Comment 3 2014-06-30 14:51:52 PDT
(In reply to comment #2) > (From update of attachment 234093 [details]) > r=me > > Any way to regression test this? Maybe even something that only crashes in Zombie mode? It was a pre-existing regression test that caught this, so I think we're ok.
Mark Hahnenberg
Comment 4 2014-06-30 15:22:59 PDT
Committed r170604: <http://trac.webkit.org/changeset/170604>
Note You need to log in before you can comment on or make changes to this bug.