Bug 134437

Summary: No need to lazily initialize ResourceResponse internals when accessing timing data.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Page LoadingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, sergio
Priority: P2 Keywords: InRadar, Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2014-06-29 13:14:59 PDT
<rdar://problem/17499876>
Attachments
Patch (4.02 KB, patch)
2014-06-29 13:15 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-06-29 13:15:48 PDT
Created attachment 234062 [details] Patch
WebKit Commit Bot
Comment 2 2014-06-29 14:51:29 PDT
Comment on attachment 234062 [details] Patch Clearing flags on attachment: 234062 Committed r170575: <http://trac.webkit.org/changeset/170575>
WebKit Commit Bot
Comment 3 2014-06-29 14:51:33 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4 2014-06-30 07:28:57 PDT
Comment on attachment 234062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234062&action=review > Source/WebCore/platform/network/ResourceResponseBase.h:120 > + ResourceLoadTiming& resourceLoadTiming() const { return m_resourceLoadTiming; } I would have expected the return value to be const& rather than just &.
Note You need to log in before you can comment on or make changes to this bug.