Bug 134437

Summary:

No need to lazily initialize ResourceResponse internals when accessing timing data.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Page Loading

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, gyuyoung.kim, sergio

Priority:

Keywords:

InRadar, Performance

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2014-06-29 13:14:59 PDT

<rdar://problem/17499876>

Comment 1 Andreas Kling 2014-06-29 13:15:48 PDT

Created attachment 234062 [details]
Patch

Comment 2 WebKit Commit Bot 2014-06-29 14:51:29 PDT

Comment on attachment 234062 [details]
Patch

Clearing flags on attachment: 234062

Committed r170575: <http://trac.webkit.org/changeset/170575>

Comment 3 WebKit Commit Bot 2014-06-29 14:51:33 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Darin Adler 2014-06-30 07:28:57 PDT

Comment on attachment 234062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234062&action=review

> Source/WebCore/platform/network/ResourceResponseBase.h:120
> +    ResourceLoadTiming& resourceLoadTiming() const { return m_resourceLoadTiming; }

I would have expected the return value to be const& rather than just &.