Bug 134430

Summary: Refactor ResourceRequest into Cocoa and iOS specific files
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: PlatformAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, bunhere, cdumez, commit-queue, gyuyoung.kim, psolanki, sam, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Pratik Solanki
Reported 2014-06-28 13:59:43 PDT
Too many ifdefs in ResourceRequestMac.mm. We should also separate out iOS specific code into a separate file.
Attachments
Patch (30.79 KB, patch)
2014-06-28 14:06 PDT, Pratik Solanki 		no flags
DetailsFormatted DiffDiff
Patch (32.16 KB, patch)
2014-06-28 22:29 PDT, Pratik Solanki 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2014-06-28 14:06:57 PDT
Created attachment 234051 [details] Patch
Pratik Solanki
Comment 2 2014-06-28 22:29:07 PDT
Created attachment 234057 [details] Patch
WebKit Commit Bot
Comment 3 2014-06-28 22:31:46 PDT
Attachment 234057 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:154: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 4 2014-06-29 09:20:24 PDT
Comment on attachment 234057 [details] Patch Great idea!
Pratik Solanki
Comment 5 2014-06-29 14:00:25 PDT
Committed r17054 - <http://trac.webkit.org/changeset/170574>
Pratik Solanki
Comment 6 2014-06-29 14:00:55 PDT
(In reply to comment #5) > Committed r17054 - <http://trac.webkit.org/changeset/170574> r170574
Sam Weinig
Comment 7 2014-06-29 16:30:45 PDT
(In reply to comment #5) > Committed r17054 - <http://trac.webkit.org/changeset/170574> You're my hero!
Note You need to log in before you can comment on or make changes to this bug.