Bug 134430

Summary: Refactor ResourceRequest into Cocoa and iOS specific files
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: PlatformAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, bunhere, cdumez, commit-queue, gyuyoung.kim, psolanki, sam, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Description Pratik Solanki 2014-06-28 13:59:43 PDT 
Too many ifdefs in ResourceRequestMac.mm. We should also separate out iOS specific code into a separate file.
Comment 1 Pratik Solanki 2014-06-28 14:06:57 PDT 
Created attachment 234051 [details]
Patch
Comment 2 Pratik Solanki 2014-06-28 22:29:07 PDT 
Created attachment 234057 [details]
Patch
Comment 3 WebKit Commit Bot 2014-06-28 22:31:46 PDT 
Attachment 234057 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:154:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andreas Kling 2014-06-29 09:20:24 PDT 
Comment on attachment 234057 [details]
Patch

Great idea!
Comment 5 Pratik Solanki 2014-06-29 14:00:25 PDT 
Committed r17054 - <http://trac.webkit.org/changeset/170574>
Comment 6 Pratik Solanki 2014-06-29 14:00:55 PDT 
(In reply to comment #5)
> Committed r17054 - <http://trac.webkit.org/changeset/170574>

r170574
Comment 7 Sam Weinig 2014-06-29 16:30:45 PDT 
(In reply to comment #5)
> Committed r17054 - <http://trac.webkit.org/changeset/170574>

You're my hero!