Bug 13442

Summary: Yahoo.com does not render properly in GDK port
Product: WebKit Reporter: Atul Mehrotra <atul.mehrotra>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: mrowe
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
yahoo.com dont show proper page because of User Agent string
none
patch for adding correct User Agent String. mrowe: review-

Description Atul Mehrotra 2007-04-21 19:08:49 PDT
Yahoo.com does not render correct page.
Comment 1 Atul Mehrotra 2007-04-21 19:16:55 PDT
Created attachment 14131 [details]
yahoo.com dont show proper page because of User Agent string
Comment 2 Atul Mehrotra 2007-04-21 19:31:21 PDT
Created attachment 14132 [details]
patch for adding correct User Agent String.
Comment 3 Mark Rowe (bdash) 2007-04-21 19:35:41 PDT
Comment on attachment 14132 [details]
patch for adding correct User Agent String.

You have a setter method which ignores its argument and uses a constant string.  You then never use the member variable which is set, instead adding another constant string.  You are also missing a ChangeLog entry.
Comment 4 Mark Rowe (bdash) 2007-04-21 19:51:14 PDT
Comment on attachment 14132 [details]
patch for adding correct User Agent String.

I'll also mention that the user agent string that you chose to use is clearly incorrect.  You are not using WebKit version 410, nor are you likely to be on a PowerPC machine running OS X.
Comment 5 Alp Toker 2007-07-02 17:44:49 PDT
yahoo.com works properly using the gdk port/GdkLauncher TOT.