Bug 134406 – Custom scrollbars should not create ScrollbarPainters on Mac

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Beth Dakin]

Pages with custom scrollbars are still creating NSScrollerImps for those scrollbars on Mac. This should not be happening.

<rdar://problem/16178301>

[Beth Dakin]

Created attachment 234005 [details]
Patch

[WebKit Commit Bot]

Attachment 234005 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/Scrollbar.cpp:59:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/Scrollbar.cpp:82:  Wrong number of spaces before statement. (expected: 25)  [whitespace/indent] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Beth Dakin]

Thanks Tim http://trac.webkit.org/changeset/170546

[Darin Adler]

Comment on attachment 234005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234005&action=review

> Source/WebCore/platform/Scrollbar.h:201
> +    bool m_isCustomScrollbar;

Why protected instead of private?

> Source/WebCore/rendering/RenderScrollbar.cpp:45
> +    : Scrollbar(scrollableArea, orientation, RegularScrollbar, RenderScrollbarTheme::renderScrollbarTheme(), true)

Makes me think we should use an enum instead of a bool for readability.

[Beth Dakin]

(In reply to comment #4)
> (From update of attachment 234005 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234005&action=review
> 
> > Source/WebCore/platform/Scrollbar.h:201
> > +    bool m_isCustomScrollbar;
> 
> Why protected instead of private?
> 

Oh, that was very silly. This should definitely be private, I just failed to notice that all of the other member variables were protected when I put this one next to them.

> > Source/WebCore/rendering/RenderScrollbar.cpp:45
> > +    : Scrollbar(scrollableArea, orientation, RegularScrollbar, RenderScrollbarTheme::renderScrollbarTheme(), true)
> 
> Makes me think we should use an enum instead of a bool for readability.

That would definitely look nicer. 

I'll do a follow-up cleanup here.