| Summary: | Update policy for Inactive Committer and Reviewer status | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||||||
| Component: | WebKit Website | Assignee: | Bem Jones-Bey <bjonesbe> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bdakin, bunhere, cdumez, commit-queue, gyuyoung.kim, sergio, zecke | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Bem Jones-Bey
2014-06-27 10:48:46 PDT
Created attachment 233996 [details]
Patch
Comment on attachment 233996 [details]
Patch
This looks good to me!
Comment on attachment 233996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233996&action=review > Websites/webkit.org/coding/commit-review-policy.html:108 > +landing at least one patch in the past year.</p> or reviewing a patch for the reviewer status. > Websites/webkit.org/coding/commit-review-policy.html:111 > +<p>Inactive Committers can regain Active Committer status by simply landing a > +non-trivial patch and asking to return to Active status.</p> We might want to separately mention that subversion account not used to commit patches into the repository for more than one year will be deactivated for security reasons. What is the issue you are trying to solve? I am a WebKit reviewer, I look at the commits from time to time, I read the webkit-dev mailinglist but I have not reviewed or landed a patch in a very long time. Given the above definition I count as inactive contributor. On the other hand I am certainly not qualified to land or review patches right now. For me it would be natural to get more familiar with the code before landing patches again. Created attachment 234015 [details]
Patch
(In reply to comment #3) > (From update of attachment 233996 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=233996&action=review > > > Websites/webkit.org/coding/commit-review-policy.html:108 > > +landing at least one patch in the past year.</p> > > or reviewing a patch for the reviewer status. > > > Websites/webkit.org/coding/commit-review-policy.html:111 > > +<p>Inactive Committers can regain Active Committer status by simply landing a > > +non-trivial patch and asking to return to Active status.</p> > > We might want to separately mention that subversion account not used to commit patches into the repository for more than one year will be deactivated for security reasons. I've uploaded a new version that incorporates these comments. (In reply to comment #4) > What is the issue you are trying to solve? I am a WebKit reviewer, I look at the commits from time to time, I read the webkit-dev mailinglist but I have not reviewed or landed a patch in a very long time. Given the above definition I count as inactive contributor. > > On the other hand I am certainly not qualified to land or review patches right now. For me it would be natural to get more familiar with the code before landing patches again. The only issue I personally am trying to solve is that for new people it can be hard to know who to talk to for reviews, since the reviewer list is long and lists many people that are no longer even as active as you are. It would satisfy me if we just made it so that these inactive reviewers were listed separately on the team.html page. There was a security concern about having lots of inactive subversion accounts, and even with having inactive accounts that have access to things like EWS. I believe that's the main point in this, but hopefully some of those that feel more strongly about it than I can elaborate. Created attachment 234565 [details]
Patch
Comment on attachment 234565 [details]
Patch
I feel it's in the spirit of this discussion if this is r+d by a (now no longer :-P) inactive reviewer.
Comment on attachment 234565 [details] Patch Clearing flags on attachment: 234565 Committed r170904: <http://trac.webkit.org/changeset/170904> All reviewed patches have been landed. Closing bug. Comment on attachment 234565 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234565&action=review > Websites/webkit.org/coding/commit-review-policy.html:127 > +Reviewer can send an email to webkit-reviewers requesting it.</p> This should be webkit-dev as committers can't post messages to webkit-reviewers. Comment on attachment 234565 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234565&action=review >> Websites/webkit.org/coding/commit-review-policy.html:127 >> +Reviewer can send an email to webkit-reviewers requesting it.</p> > > This should be webkit-dev as committers can't post messages to webkit-reviewers. Or maybe webkit-committers? (same with committers wanting to be reactivated?) (In reply to comment #13) > (From update of attachment 234565 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234565&action=review > > >> Websites/webkit.org/coding/commit-review-policy.html:127 > >> +Reviewer can send an email to webkit-reviewers requesting it.</p> > > > > This should be webkit-dev as committers can't post messages to webkit-reviewers. > > Or maybe webkit-committers? (same with committers wanting to be reactivated?) Haven't heard back, so I've created a patch with this change: https://bugs.webkit.org/show_bug.cgi?id=135203 |