Bug 134402

Summary:

[ARMv7] Skip one particularly expensive fastFree() alignment check.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Web Template Framework

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, bunhere, cdumez, cmarcelo, commit-queue, ggaren, gyuyoung.kim, kling, oliver, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	barraclough: review+

Description Andreas Kling 2014-06-27 10:16:21 PDT

__umodsi3 is lava hot on PLT!

Comment 1 Andreas Kling 2014-06-27 10:20:39 PDT

Created attachment 233993 [details]
Patch

Comment 2 Andreas Kling 2014-06-27 11:07:10 PDT

Committed r170536: <http://trac.webkit.org/changeset/170536>

Comment 3 Darin Adler 2014-06-27 14:14:44 PDT

Comment on attachment 233993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233993&action=review

> Source/WTF/wtf/FastMalloc.cpp:4171
> +#if !(CPU(ARM_THUMB2) && !CPU(APPLE_ARMV7S))

Really needs a why comment. Would be very mysterious to a future reader.