Bug 134402

Summary: [ARMv7] Skip one particularly expensive fastFree() alignment check.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Web Template FrameworkAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, bunhere, cdumez, cmarcelo, commit-queue, ggaren, gyuyoung.kim, kling, oliver, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch barraclough: review+

Andreas Kling
Reported 2014-06-27 10:16:21 PDT
__umodsi3 is lava hot on PLT!
Attachments
Patch (1.38 KB, patch)
2014-06-27 10:20 PDT, Andreas Kling 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-06-27 10:20:39 PDT
Created attachment 233993 [details] Patch
Andreas Kling
Comment 2 2014-06-27 11:07:10 PDT
Committed r170536: <http://trac.webkit.org/changeset/170536>
Darin Adler
Comment 3 2014-06-27 14:14:44 PDT
Comment on attachment 233993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233993&action=review > Source/WTF/wtf/FastMalloc.cpp:4171 > +#if !(CPU(ARM_THUMB2) && !CPU(APPLE_ARMV7S)) Really needs a why comment. Would be very mysterious to a future reader.
Note You need to log in before you can comment on or make changes to this bug.