Bug 134362

Summary: Skip memcmp()ing fully downloaded resources after they become mmap()able.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Page LoadingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, bunhere, cdumez, commit-queue, gyuyoung.kim, japhet, kling, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Andreas Kling
Reported 2014-06-26 14:43:02 PDT
CachedResource::tryReplaceEncodedData() does a memcmp() to check that the data being replaced is exactly equal to the disk-cached version. This is always the case, and we're wasting a bunch of time doing these comparisons. Let's turn them into assertions.
Attachments
Patch (2.04 KB, patch)
2014-06-26 14:44 PDT, Andreas Kling 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-06-26 14:44:37 PDT
Created attachment 233936 [details] Patch
Geoffrey Garen
Comment 2 2014-06-26 14:55:59 PDT
Comment on attachment 233936 [details] Patch r=me
Andreas Kling
Comment 3 2014-06-26 15:23:07 PDT
Committed r170499: <http://trac.webkit.org/changeset/170499>
Note You need to log in before you can comment on or make changes to this bug.