Bug 134352

Summary: [MSE] Refactoring: Use C++11 for-loops in SourceBuffer.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, calvaris, cdumez, commit-queue, eric.carlson, glenn, gyuyoung.kim, ltilve, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Description Jer Noble 2014-06-26 11:21:48 PDT 
[MSE] Refactoring: Use C++11 for-loops in SourceBuffer.
Comment 1 Jer Noble 2014-06-26 11:28:18 PDT 
Created attachment 233918 [details]
Patch
Comment 2 Darin Adler 2014-06-26 11:35:57 PDT 
Comment on attachment 233918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233918&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:316
> +        AtomicString trackID = trackBufferPair.key;

Wasting a little performance here by using AtomicString instead of const AtomicString& or auto&.
Comment 3 Jer Noble 2014-06-26 11:45:17 PDT 
(In reply to comment #2)
> (From update of attachment 233918 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233918&action=review
> 
> > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:316
> > +        AtomicString trackID = trackBufferPair.key;
> 
> Wasting a little performance here by using AtomicString instead of const AtomicString& or auto&.

Good point.  Will fix that (as well as a compilation error) before landing.
Comment 4 Jer Noble 2014-06-26 11:50:57 PDT 
Committed r170488: <http://trac.webkit.org/changeset/170488>