Bug 134339 – Add option to specify output file location in sunspider.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Gergő Balogh]

There is not any way to specify the output path for sunspider scripts, without changing these scripts.

[Gergő Balogh]

Created attachment 233889 [details]
patch

[Csaba Osztrogonác]

Comment on attachment 233889 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233889&action=review

The base idea is good, but r- now due to some minor issue.

> PerformanceTests/SunSpider/sunspider:45
> +my $outputPath = "";

We don't need this extra variable, we can use this one:
my $resultsFile = "";

> PerformanceTests/SunSpider/sunspider:61
> +  --output-path     If given set the output file and its path.

I prefer --output.

> PerformanceTests/SunSpider/sunspider:75
> +           'output-path=s' => \$outputPath,

'output=s' => \$resultsFile,

> PerformanceTests/SunSpider/sunspider:131
>  my $resultsFile = "$resultDirectory/sunspider-results-$timeString.js";
> +if ($outputPath) {
> +  $resultsFile = $outputPath;
> +}

You can do it in one line:
$resultsFile = "$resultDirectory/sunspider-results-$timeString.js" unless $resultsFile;

> Tools/Scripts/run-sunspider:65
> +  --output-path     If given set the output file and its path.

Simple --output would be better name, and the comment like "Override the default output path and filename"

[Gergő Balogh]

Created attachment 234332 [details]
patch fix

[WebKit Commit Bot]

Comment on attachment 234332 [details]
patch fix

Rejecting attachment 234332 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 234332, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/sunspider
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/run-sunspider
Hunk #1 succeeded at 46 with fuzz 2.
Hunk #2 succeeded at 64 (offset 2 lines).
Hunk #3 succeeded at 78 (offset 3 lines).
Hunk #4 FAILED at 128.
1 out of 4 hunks FAILED -- saving rejects to file Tools/Scripts/run-sunspider.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4924038950420480

[Gergő Balogh]

Created attachment 234552 [details]
patch for landing

[Build Bot]

Comment on attachment 234552 [details]
patch for landing

Attachment 234552 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6062567940161536

New failing tests:
media/media-fragments/TC0001.html

[Build Bot]

Created attachment 234553 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[WebKit Commit Bot]

Comment on attachment 234552 [details]
patch for landing

Clearing flags on attachment: 234552

Committed r170881: <http://trac.webkit.org/changeset/170881>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.