Bug 134319

Summary:

[iOS]: Tapping <button> outside of a form is no longer working

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, bunhere, cdumez, commit-queue, dbates, ddkilzer, esprehn+autocc, gyuyoung.kim, joepeck, sergio

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	dbates: review+, dbates: commit-queue-

Description Joseph Pecoraro 2014-06-25 17:34:39 PDT

Reduction:

    <button>Test Button</button>
    <script>
    document.addEventListener('click', function() {
        alert('click');
    }, false);
    </script>

This is no longer working. It looks like when upstreaming iOS WebKit we changed HTMLButtonElement::willRespondToMouseClickEvents away from the iOS implementation to the OpenSource (Chromium / Android implementation). We should revert back to the iOS implementation that supports <button> outside of a <form>.

Comment 1 Joseph Pecoraro 2014-06-25 17:34:50 PDT

<rdar://problem/17213346>

Comment 2 Joseph Pecoraro 2014-06-25 17:37:04 PDT

Created attachment 233856 [details]
[PATCH] Proposed Fix

Comment 3 Daniel Bates 2014-06-25 18:38:10 PDT

Comment on attachment 233856 [details]
[PATCH] Proposed Fix

Can we write a DRT test for this?

Comment 4 Daniel Bates 2014-06-25 18:39:16 PDT

Comment on attachment 233856 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=233856&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=134319

Please list the radar URL under the WebKit bug URL.

Comment 5 Joseph Pecoraro 2014-06-26 11:34:15 PDT

<http://trac.webkit.org/changeset/170487>

Comment 6 Joseph Pecoraro 2014-06-26 11:34:37 PDT

(In reply to comment #3)
> (From update of attachment 233856 [details])
> Can we write a DRT test for this?

Hmm, probably. I'll look into this.