Bug 134313

Summary: Web Inspector: Command-/ (slash) now auto-comments code via CodeMirror 4. Should remove as command to pause
Product: WebKit Reporter: Jonathan Wells <jonowells>
Component: Web InspectorAssignee: Jonathan Wells <jonowells>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, bunhere, cdumez, commit-queue, graouts, gyuyoung.kim, joepeck, rniwa, sergio, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change from cmd-/ to cmd-\
none
[PATCH] Proposed change from cmd-/ to cmd-\
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
none
[PATCH] Proposed change from cmd-/ to cmd-\ none

Jonathan Wells
Reported 2014-06-25 16:06:06 PDT
Command-Control-Y pauses/continues the debugger already, so we should leave this shortcut as is and remove Command-/ and the associated hint in the UI as a way of pausing/continuing. This mirrors the behavior in Xcode which also has auto-commenting on Command-/.
Attachments
[PATCH] Proposed change from cmd-/ to cmd-\ (3.43 KB, patch)
2014-06-25 17:00 PDT, Jonathan Wells 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed change from cmd-/ to cmd-\ (3.43 KB, patch)
2014-06-25 17:08 PDT, Jonathan Wells 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (524.23 KB, application/zip)
2014-06-25 18:18 PDT, Build Bot 		no flags
Details
[PATCH] Proposed change from cmd-/ to cmd-\ (3.43 KB, patch)
2014-06-26 12:56 PDT, Jonathan Wells 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-06-25 16:06:51 PDT
<rdar://problem/17459995>
Jonathan Wells
Comment 2 2014-06-25 17:00:20 PDT
Created attachment 233852 [details] [PATCH] Proposed change from cmd-/ to cmd-\
Jonathan Wells
Comment 3 2014-06-25 17:08:56 PDT
Created attachment 233854 [details] [PATCH] Proposed change from cmd-/ to cmd-\
Build Bot
Comment 4 2014-06-25 18:18:03 PDT
Comment on attachment 233854 [details] [PATCH] Proposed change from cmd-/ to cmd-\ Attachment 233854 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5724316314370048 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Build Bot
Comment 5 2014-06-25 18:18:07 PDT
Created attachment 233861 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Jonathan Wells
Comment 6 2014-06-25 18:25:53 PDT
Seems like we have an unrelated flaky test.
Jonathan Wells
Comment 7 2014-06-26 12:56:30 PDT
Created attachment 233927 [details] [PATCH] Proposed change from cmd-/ to cmd-\
Timothy Hatcher
Comment 8 2014-06-26 14:43:18 PDT
Comment on attachment 233927 [details] [PATCH] Proposed change from cmd-/ to cmd-\ We could just remove the alternate too. But this is fine.
Joseph Pecoraro
Comment 9 2014-06-26 14:59:07 PDT
Comment on attachment 233927 [details] [PATCH] Proposed change from cmd-/ to cmd-\ View in context: https://bugs.webkit.org/attachment.cgi?id=233927&action=review > Source/WebInspectorUI/UserInterface/Models/KeyboardShortcut.js:158 > Slash: new WebInspector.Key(191, "/"), > + Backslash: new WebInspector.Key(220, "\\"), > Apostrophe: new WebInspector.Key(192, "`"), Nit: This is sorted in numeric order, you could put this after Apostrophe.
WebKit Commit Bot
Comment 10 2014-06-26 15:16:13 PDT
Comment on attachment 233927 [details] [PATCH] Proposed change from cmd-/ to cmd-\ Clearing flags on attachment: 233927 Committed r170497: <http://trac.webkit.org/changeset/170497>
WebKit Commit Bot
Comment 11 2014-06-26 15:16:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.