Bug 134312

Summary: remove pointer lock prefixes
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebCore Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Minor CC: beidson, bunhere, cdumez, cmarcelo, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kangil.han, kondapallykalyan, sergio, syoichi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Alex Christensen 2014-06-25 16:05:04 PDT
The pointer lock code has webkit prefixes.  If we enable it, we will not want to have prefixes.
Comment 1 Alex Christensen 2014-06-25 16:10:36 PDT
Created attachment 233845 [details]
Patch
Comment 2 Brady Eidson 2014-06-25 20:03:33 PDT
1 - Does any other platform enable PointerLock?

2 - If so, have they shipped with the prefixes?

3 - If so, do they need the prefixes to stay?

You might need to explore the answers to #2 and #3 on webkit-dev
Comment 3 Alex Christensen 2014-06-26 10:32:55 PDT
Chrome hasn't shipped an unprefixed version yet, but it's been in their codebase since https://src.chromium.org/viewvc/blink?revision=173766&view=revision
Comment 4 Brady Eidson 2014-06-26 11:44:36 PDT
(In reply to comment #3)
> Chrome hasn't shipped an unprefixed version yet, but it's been in their codebase since https://src.chromium.org/viewvc/blink?revision=173766&view=revision

I'm not talking about other browsers/engines - I'm talking about other ports of WebKit.  Here, in this project.
Comment 5 Alex Christensen 2014-06-26 14:06:09 PDT
(In reply to comment #4)
> I'm not talking about other browsers/engines - I'm talking about other ports of WebKit.  Here, in this project.
I know.  I just thought I'd add the relevant information.  I'm pretty sure they're the only ones who ever shipped the webkit-prefixed pointer lock and they're no longer in trunk, so let's put this in next week unless someone opposes with a valid reason.
Comment 6 Dean Jackson 2014-06-28 15:55:08 PDT
Comment on attachment 233845 [details]
Patch

No one has complained yet. I guess wait for another day and then go ahead.
Comment 7 WebKit Commit Bot 2014-06-30 09:59:47 PDT
Comment on attachment 233845 [details]
Patch

Clearing flags on attachment: 233845

Committed r170585: <http://trac.webkit.org/changeset/170585>
Comment 8 WebKit Commit Bot 2014-06-30 09:59:52 PDT
All reviewed patches have been landed.  Closing bug.