Bug 134299

Summary:

REGRESSION (r170426) Broke two python unit tests

Product:

WebKit

Reporter:

Michal Pakula vel Rutka <mpakulavelrutka>

Component:

WebKit EFL

Assignee:

Michal Pakula vel Rutka <mpakulavelrutka>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, glenn, gyuyoung.kim, lucas.de.marchi, ossy, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

134195

Attachments:

Description	Flags
patch	ossy: review+, ossy: commit-queue-

Description Michal Pakula vel Rutka 2014-06-25 07:51:48 PDT

SSIA

Comment 1 Michal Pakula vel Rutka 2014-06-25 07:53:40 PDT

Created attachment 233812 [details]
patch

Comment 2 WebKit Commit Bot 2014-06-25 07:54:46 PDT

Attachment 233812 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/port/efl.py:113:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Csaba Osztrogonác 2014-06-25 08:07:28 PDT

Comment on attachment 233812 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233812&action=review

r=me

> Tools/Scripts/webkitpy/port/efl.py:113
> +        search_paths.append(self.port_name + '-wk2');

Please remove the extra semicolon before landing.

Comment 4 Michal Pakula vel Rutka 2014-06-25 08:09:51 PDT

Committed r170427: <http://trac.webkit.org/changeset/170427>